Message-ID: <5555FEC4.6050204@collabora.co.uk>
Date: Fri, 15 May 2015 16:12:20 +0200
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version: 1.0
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
        Kukjin Kim <kgene@kernel.org>, Russell King <linux@arm.linux.org.uk>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
CC: linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 0/4] ARM: multi_v7_defconfig: Stuff for Exynos
References: <1431694142-32141-1-git-send-email-k.kozlowski.k@gmail.com>
In-Reply-To: <1431694142-32141-1-git-send-email-k.kozlowski.k@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1535
Lines: 47

Hello Krzysztof,

On 05/15/2015 02:48 PM, Krzysztof Kozlowski wrote:
> Dear Kukjin,
> 
> The patchset enables various config options on multi_v7 config
> for Exynos boards. The first two patches are actually resend.
> 
> Arnd suggested [0] that this can go through your tree.
> 
> Patchset is rebased on next-20150515 and Javier's patchset [1]
> (to avoid conflicts around regulators and clocks).
> 
> Please let me know if this should be rebased on other commit.
> 
> [0] http://www.spinics.net/lists/kernel/msg1991518.html
> [1] http://www.spinics.net/lists/kernel/msg1990767.html
> 
> Best regards,
> Krzysztof
> 
> 
> Krzysztof Kozlowski (4):
>   ARM: multi_v7_defconfig: Enable CPU idle for Exynos
>   ARM: multi_v7_defconfig: Enable PMIC and MUIC drivers for Exynos
>     boards
>   ARM: multi_v7_defconfig: Enable TMU for Exynos
>   ARM: multi_v7_defconfig: Enable OHCI on Exynos
> 
>  arch/arm/configs/multi_v7_defconfig | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

On a first look, I agree with all the Kconfig symbols but I noticed that
you are adding them to be built-in while the current policy for multi_v7
is to build as much as possible as a module.

Could you please add as =m for all the tristate symbols that can be build
as a module?

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/