Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934056AbbEOOSK (ORCPT ); Fri, 15 May 2015 10:18:10 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33710 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933599AbbEOOSE (ORCPT ); Fri, 15 May 2015 10:18:04 -0400 MIME-Version: 1.0 In-Reply-To: <1431349882-12260-5-git-send-email-s.hauer@pengutronix.de> References: <1431349882-12260-1-git-send-email-s.hauer@pengutronix.de> <1431349882-12260-5-git-send-email-s.hauer@pengutronix.de> From: Daniel Kurtz Date: Fri, 15 May 2015 22:17:43 +0800 X-Google-Sender-Auth: q5CH2VB879HJ5wpSMHW-B_JeSkc Message-ID: Subject: Re: [PATCH 4/4] ARM64: MediaTek MT8173: Add SCPSYS device node To: Sascha Hauer Cc: "linux-arm-kernel@lists.infradead.org" , "open list:OPEN FIRMWARE AND..." , Kevin Hilman , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org, Sasha Hauer , Matthias Brugger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2464 Lines: 61 On Mon, May 11, 2015 at 9:11 PM, Sascha Hauer wrote: > This adds the SCPSYS device node to the MT8173 dtsi file. > > Signed-off-by: Sascha Hauer > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 924fdb6..3c569b5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -125,6 +125,18 @@ > ; > }; > > + scpsys: scpsys@10006000 { > + compatible = "mediatek,mt8173-scpsys"; > + #power-domain-cells = <1>; > + reg = <0 0x10006000 0 0x1000>; > + clocks = <&topckgen CLK_TOP_VDEC_SEL>, > + <&topckgen CLK_TOP_MFG_SEL>, > + <&topckgen CLK_TOP_VENC_SEL>, > + <&topckgen CLK_TOP_MM_SEL>, > + <&topckgen CLK_TOP_VENC_LT_SEL>; > + clock-names = "vdec", "mfg", "venc", "disp", "ven2"; (1) I think people like to align multi-line dts field values, so there should be one more ' ' before each <&topckgen ...>. (2) it is a bit awkward that these names do not match their clock names. This seems more straightforward: clock-names = "vdec", "mfg", "venc", "mm", "venc_lt"; (3) the scpsys binding patch does not list the clock fields. (4) I don't think a patch with these CLK_TOP_* has been sent to the list for review yet. Thanks, -Dan > + }; > + > sysirq: intpol-controller@10200620 { > compatible = "mediatek,mt8173-sysirq", > "mediatek,mt6577-sysirq"; > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/