Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754540AbbEOOlO (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 May 2015 10:41:14 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:40679 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934448AbbEOOlI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 May 2015 10:41:08 -0400
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
X-AuditID: cbfec7f4-f79c56d0000012ee-35-555605819eae
Content-transfer-encoding: 8BIT
Message-id: <55560580.8070404@samsung.com>
Date: Fri, 15 May 2015 16:41:04 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
To: Stas Sergeev <stsp@list.ru>
Cc: linux-leds@vger.kernel.org, Linux kernel <linux-kernel@vger.kernel.org>,
        Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Stas Sergeev <stsp@users.sourceforge.net>
Subject: Re: [PATCH v2] leds: fix brightness changing when software blinking is
 active
References: <5554BE12.7050209@list.ru> <5555AA7F.1000001@samsung.com>
 <5555FDFF.5060402@samsung.com> <5555FE9D.20103@list.ru>
In-reply-to: <5555FE9D.20103@list.ru>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t/xy7qNrGGhBounmFkc3TmRyeJs0xt2
	i8u75rBZbH2zjtFi966nrBatmxqYLTr7prE4sHvsnHWX3ePelsvMHnvm/2D16NuyitGj6VQ7
	q8fnTXIBbFFcNimpOZllqUX6dglcGU8nTWYreMJR8Wb2M7YGxunsXYycHBICJhIzOy4yQdhi
	EhfurWfrYuTiEBJYyigx4dosNpAEr4CgxI/J91i6GDk4mAXkJY5cygYJMwuYSTxqWccMUf+M
	UeLXo+msEPVaEi92t4MNZRFQlXj26QIziM0mYCjx88VrsLioQITEn9P7WEFmigDN3NBYBjKH
	WeAVo8TLVw8ZQWqEgWrapx1mAbGFBOollszuZwep5wSa+bFdfAKjwCwk181CuG4WkusWMDKv
	YhRNLU0uKE5KzzXUK07MLS7NS9dLzs/dxAgJ9S87GBcfszrEKMDBqMTDe2NlaKgQa2JZcWXu
	IUYJDmYlEd4ahrBQId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgsky
	cXBKNTCWH7Xm6VVf8rBESt/o9ObtX49eVO2y+/G+7nOe8rwlshGXT7xuXl5+JOtf7Io/TDLK
	JWsZBOrtGuV/psy6Li7JyjKhys/hVvKyV3JfFQ33M3zjrzzRfujoTcHZLXZRnEcl2HiZNh87
	nL2pbOVhncCiTQZCt2fW1Mf/3cCcpfX8T43vxhq5q4+UWIozEg21mIuKEwGWQvMHcQIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1334
Lines: 40

On 05/15/2015 04:11 PM, Stas Sergeev wrote:
> 15.05.2015 17:09, Jacek Anaszewski пишет:
>> On 05/15/2015 10:12 AM, Jacek Anaszewski wrote:
>>> Hi Stas,
>>>
>>> On 05/14/2015 05:24 PM, Stas Sergeev wrote:
>>>>
>>>> The following sequence:
>>>> echo timer >/sys/class/leds/<name>/trigger
>>>> echo 1 >/sys/class/leds/<name>/brightness
>>>> should change the ON brightness for blinking.
>>>> The function led_set_brightness() was mistakenly initiating the
>>>> delayed blink stop procedure, which resulted in no blinking with
>>>> the timer trigger still active.
>>>>
>>>> This patch fixes the problem by changing led_set_brightness()
>>>> to not initiate the delayed blink stop when brightness is not 0.
>>
>> This commit message is not valid for this version of the patch.
> Why do you think so?
> ---
> -		schedule_work(&led_cdev->set_brightness_work);
> +		if (brightness == LED_OFF)
> +			schedule_work(&led_cdev->set_brightness_work);
> ---
>
> LED_OFF is a 0 define.
>

You're right, I was just looking at the issue from different
perspective.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/