Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934846AbbEORNA (ORCPT ); Fri, 15 May 2015 13:13:00 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:37194 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933823AbbEORM5 (ORCPT ); Fri, 15 May 2015 13:12:57 -0400 MIME-Version: 1.0 In-Reply-To: <1431691653-17615-1-git-send-email-bilhuang@nvidia.com> References: <1431691653-17615-1-git-send-email-bilhuang@nvidia.com> Date: Fri, 15 May 2015 10:12:56 -0700 X-Google-Sender-Auth: Z1I2kXEpviL--r2GEdU2PDfu6Go Message-ID: Subject: Re: [PATCH 1/1] clk: tegra: fix WARN_ON in PLL_RE registration From: Benson Leung To: Bill Huang Cc: Peter De Schrijver , Mike Turquette , Stephen Warren , Thierry Reding , Paul Walmsley , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 51 On Fri, May 15, 2015 at 5:07 AM, Bill Huang wrote: > This fixes two things. > > - Read the correct IDDQ register > - Check the correct IDDQ bit position > > Signed-off-by: Bill Huang Reviewed-by: Benson Leung By the way, does it also make sense to do the same thing for tegra_clk_register_pllss, which also reads the base register instead of the specific iddq_reg from params? > --- > drivers/clk/tegra/clk-pll.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c > index 05c6d08..734340e 100644 > --- a/drivers/clk/tegra/clk-pll.c > +++ b/drivers/clk/tegra/clk-pll.c > @@ -1630,7 +1630,8 @@ struct clk *tegra_clk_register_pllre(const char *name, const char *parent_name, > > val = pll_readl_base(pll); > if (val & PLL_BASE_ENABLE) > - WARN_ON(val & pll_params->iddq_bit_idx); > + WARN_ON(readl_relaxed(clk_base + pll_params->iddq_reg) & > + BIT(pll_params->iddq_bit_idx)); > else { > int m; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/