Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934502AbbEORd3 (ORCPT ); Fri, 15 May 2015 13:33:29 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:33704 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934161AbbEORd0 convert rfc822-to-8bit (ORCPT ); Fri, 15 May 2015 13:33:26 -0400 Date: Fri, 15 May 2015 19:33:15 +0200 From: David Hildenbrand To: Christian Borntraeger Cc: Alex =?UTF-8?B?QmVubsOpZQ==?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, r65777@freescale.com, bp@suse.de, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , "supporter:S390" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE..." , Gleb Natapov , Bharat Bhushan , Alexey Kardashevskiy , Mihai Caraman , Cornelia Huck , Michael Mueller , Eric Farman , Dominik Dingel , Tony Krowiak , "Jason J. Herne" , Nadav Amit , "open list:LINUX FOR POWERPC..." , open list , "open list: S390" , "open list: ABI/API" Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits Message-ID: <20150515193315.6d3e82d2@thinkpad-w530> In-Reply-To: <555613F2.9060204@de.ibm.com> References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> <555613F2.9060204@de.ibm.com> Organization: IBM Deutschland GmbH X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15051517-0029-0000-0000-000004A0E1D3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1619 Lines: 46 > Am 15.05.2015 um 16:27 schrieb Alex Bennée: > > +++ b/arch/s390/include/uapi/asm/kvm.h > > @@ -114,8 +114,6 @@ struct kvm_fpu { > > __u64 fprs[16]; > > }; > > > > -#define KVM_GUESTDBG_USE_HW_BP 0x00010000 > [...] > > +++ b/include/uapi/linux/kvm.h > [...] > > +#define KVM_GUESTDBG_USE_SW_BP (1 << 16) > > +#define KVM_GUESTDBG_USE_HW_BP (1 << 17) > > This is an ABI break for s390, no? > > David, do you remember why we do not use KVM_GUESTDBG_USE_SW_BP? > We never had to tell the kernel about software breakpoints as this is all handled via 4 byte DIAG instructions until now. We don't have to turn this mechanism on. QEMU can directly insert the desired DIAG instructions and gets notified when they are about to get executed. (But we still have 2 byte breakpoint support todo - still tbd how exactly this will be realized - could be turned on via such a mechanism) The problem is, that these bits are arch specific, now Alex wants to unify them for all archs. So yes, this is an ABI break for us and breaks hardware breakpoints.(I think the first version of this patch didn't contain this ABI break when I had a look) I wonder if it wouldn't make more sense to - introduce new bits in the arch-unspecific section - rework the existing implementers to accept both bits Or to simply leave stuff as it is and handle it via arch specific bits. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/