Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755005AbbEOSBM (ORCPT ); Fri, 15 May 2015 14:01:12 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:41173 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754948AbbEOSBI (ORCPT ); Fri, 15 May 2015 14:01:08 -0400 Date: Fri, 15 May 2015 11:01:05 -0700 From: Guenter Roeck To: Fu Wei Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Timur Tabi , Ashwin Chaugule , Arnd Bergmann , vgandhi@codeaurora.org, wim@iguana.be, Jon Masters , Leo Duran , Jon Corbet Subject: Re: [PATCH 4/6] Watchdog: introdouce "pretimeout" into framework Message-ID: <20150515180105.GB19230@roeck-us.net> References: <=fu.wei@linaro.org> <1431689090-3125-1-git-send-email-fu.wei@linaro.org> <5555F5C5.8050806@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 37 On Fri, May 15, 2015 at 09:49:07PM +0800, Fu Wei wrote: > Hi Guenter, > > Great thanks for your review, > feedback inline below :-) > > On 15 May 2015 at 21:33, Guenter Roeck wrote: [ ... ] > >> + if (wdd->max_pretimeout && wdd->max_timeout < wdd->max_pretimeout) > >> { > >> + pr_info("Invalid max timeout, resetting to max > >> pretimeout!\n"); > >> + wdd->max_timeout = wdd->max_pretimeout; > >> + } > > > > > > I am a bit concerned about the context dependency introduced here. If > > someone calls > > _init_pretimeout after calling init_timeout, this may result in still > > invalid timeout > > values. > > yes, that logic is not very clean, so my thought is : > maybe we can integrate watchdog_init_timeout and watchdog_init_pretimeout, > if maintainer agree to add pretimeout into framework. > I think we should just assume that Wim will accept it, and try to find the best possible solution (or at least a good one). Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/