Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934939AbbEOUMg (ORCPT ); Fri, 15 May 2015 16:12:36 -0400 Received: from smtp0.kfki.hu ([148.6.0.25]:59374 "EHLO smtp0.kfki.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934313AbbEOUMf (ORCPT ); Fri, 15 May 2015 16:12:35 -0400 X-Greylist: delayed 444 seconds by postgrey-1.27 at vger.kernel.org; Fri, 15 May 2015 16:12:34 EDT Date: Fri, 15 May 2015 22:05:44 +0200 (CEST) From: Jozsef Kadlecsik To: Pablo Neira Ayuso cc: Denys Vlasenko , "David S. Miller" , "Eric W. Biederman" , Jan Engelhardt , Jiri Pirko , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH] netfilter: ipset: deinline ip_set_put_extensions() In-Reply-To: <20150514105605.GA4852@salvia> Message-ID: References: <1430922537-28428-1-git-send-email-dvlasenk@redhat.com> <20150514105605.GA4852@salvia> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 33 On Thu, 14 May 2015, Pablo Neira Ayuso wrote: > On Wed, May 06, 2015 at 04:28:57PM +0200, Denys Vlasenko wrote: > > On x86 allyesconfig build: > > The function compiles to 489 bytes of machine code. > > It has 25 callsites. > > > > text data bss dec hex filename > > 82441375 22255384 20627456 125324215 7784bb7 vmlinux.before > > 82434909 22255384 20627456 125317749 7783275 vmlinux > > Jozsef, I'm going to applied this patch to nf-next. Thanks! > I think that things like ip_set_put_skbinfo() can be also deinlined > and move to the core as exported symbol as this run from the control > plane path (ie. netlink). I'll add the patch for that to the next round of the ipset patches. Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/