Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945981AbbEOUlr (ORCPT ); Fri, 15 May 2015 16:41:47 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36882 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934954AbbEOUlp (ORCPT ); Fri, 15 May 2015 16:41:45 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150428181203.35812.60474.stgit@dwillia2-desk3.amr.corp.intel.com> <20150428182423.35812.20930.stgit@dwillia2-desk3.amr.corp.intel.com> Date: Fri, 15 May 2015 13:41:43 -0700 Message-ID: Subject: Re: [Linux-nvdimm] [PATCH v2 02/20] libnd, nd_acpi: initial libnd infrastructure and NFIT support From: Dan Williams To: Jeff Moyer Cc: linux-nvdimm , Linux ACPI , "Rafael J. Wysocki" , Robert Moore , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2023 Lines: 59 On Fri, May 15, 2015 at 12:44 PM, Jeff Moyer wrote: > Dan Williams writes: > > Looks like the Kconfig stuff has been worked out between you and Rafael, > so I won't comment on that. > >> diff --git a/drivers/block/nd/acpi.c b/drivers/block/nd/acpi.c >> new file mode 100644 >> index 000000000000..9f0b24390d1b >> --- /dev/null >> +++ b/drivers/block/nd/acpi.c >> @@ -0,0 +1,475 @@ >> +/* >> + * Copyright(c) 2013-2015 Intel Corporation. All rights reserved. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of version 2 of the GNU General Public License as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, but >> + * WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + * General Public License for more details. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include "acpi_nfit.h" >> +#include "libnd.h" >> + >> +static bool warn_checksum; >> +module_param(warn_checksum, bool, S_IRUGO|S_IWUSR); >> +MODULE_PARM_DESC(warn_checksum, "Turn checksum errors into warnings"); > > Is this just a debugging option? Yes, but I've deleted it in the next rev of the code since the ACPI core will have already done the checksum. The driver need not implement it's own checksum. >> + >> +enum { >> + NFIT_ACPI_NOTIFY_TABLE = 0x80, >> +}; > > This is unused by this patch. Yes. I went ahead and deleted all the ACPI notification infrastructure until we're ready to implement hot-add. > The rest looks ok to me. Thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/