Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161124AbbEOU6E (ORCPT ); Fri, 15 May 2015 16:58:04 -0400 Received: from www.linutronix.de ([62.245.132.108]:43120 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161002AbbEOU6A (ORCPT ); Fri, 15 May 2015 16:58:00 -0400 Date: Fri, 15 May 2015 22:57:46 +0200 (CEST) From: Thomas Gleixner To: Jiang Liu cc: Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC v1 00/11] Split struct irq_data into common part and per-chip part In-Reply-To: <1430709339-29083-1-git-send-email-jiang.liu@linux.intel.com> Message-ID: References: <1430709339-29083-1-git-send-email-jiang.liu@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 21 On Mon, 4 May 2015, Jiang Liu wrote: > Hi all, > Now the irq core supports hierarchy irq and stacked irqchips, > so there may be multiple irq_datas associated with the same irq. But > some fields in struct irq_data are per-irq instance and duplicating > those fields into multiple irq_data may cause troubles. > So this patch introduces a new data structure 'struct > irq_common_data' to host per-irq instance data fields, and struct > irq_data will only host per-chip data fields after the conversion. I really like that change in general. Please address the few review comments and resubmit. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/