Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946139AbbEOVN1 (ORCPT ); Fri, 15 May 2015 17:13:27 -0400 Received: from www.sr71.net ([198.145.64.142]:44826 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422755AbbEOVNY (ORCPT ); Fri, 15 May 2015 17:13:24 -0400 Message-ID: <55566173.5020402@sr71.net> Date: Fri, 15 May 2015 14:13:23 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Gleixner CC: linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 06/12] x86, pkeys: store protection in high VMA flags References: <20150507174132.34AF8FAF@viggo.jf.intel.com> <20150507174134.49B148E4@viggo.jf.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 19 On 05/15/2015 02:10 PM, Thomas Gleixner wrote: > On Thu, 7 May 2015, Dave Hansen wrote: >> +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS >> +#define VM_HIGH_ARCH_1 0x100000000 /* bit only usable on 64-bit architectures */ > > Nit. Shouldn't this start with VM_HIGH_ARCH_0 ? Yeah, it does make the later #defines look a bit funny. I modeled it after the "low" VM_ARCH_ flags which start at 1: #define VM_ARCH_1 0x01000000 /* Architecture-specific flag */ #define VM_ARCH_2 0x02000000 I can change it to be 0 based though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/