Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934694AbbEPJIl (ORCPT ); Sat, 16 May 2015 05:08:41 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:33087 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934553AbbEPJIh (ORCPT ); Sat, 16 May 2015 05:08:37 -0400 MIME-Version: 1.0 In-Reply-To: <1431763110-443-2-git-send-email-yingjoe.chen@mediatek.com> References: <1431763110-443-1-git-send-email-yingjoe.chen@mediatek.com> <1431763110-443-2-git-send-email-yingjoe.chen@mediatek.com> Date: Sat, 16 May 2015 11:08:36 +0200 Message-ID: Subject: Re: [PATCH v2 1/9] ARM: correct secondary_startup_arm mode From: Matthias Brugger To: Yingjoe Chen Cc: Mark Rutland , Thomas Gleixner , Russell King , Arnd Bergmann , Olof Johansson , "devicetree@vger.kernel.org" , Stephen Boyd , Pawel Moll , Catalin Marinas , Daniel Lezcano , "linux-kernel@vger.kernel.org" , Marc Carino , Rob Herring , linux-mediatek@lists.infradead.org, Sascha Hauer , srv_heupstream , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 41 2015-05-16 9:58 GMT+02:00 Yingjoe Chen : > secondary_startup_arm is used as ARM mode secondary start up function > when ther kernel is compiled in THUMB mode, however the label itself > is still in .thumb mode. readelf shows: > > 160979: c020a581 120 FUNC GLOBAL DEFAULT 2 secondary_startup_arm > > Make sure the label is in ARM mode as well. > > Signed-off-by: Yingjoe Chen > --- > arch/arm/kernel/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S > index 3637973..58ee8a2 100644 > --- a/arch/arm/kernel/head.S > +++ b/arch/arm/kernel/head.S > @@ -346,8 +346,8 @@ __turn_mmu_on_loc: > > #if defined(CONFIG_SMP) > .text > -ENTRY(secondary_startup_arm) > .arm > +ENTRY(secondary_startup_arm) > THUMB( adr r9, BSYM(1f) ) @ Kernel is entered in ARM. > THUMB( bx r9 ) @ If this is a Thumb-2 kernel, > THUMB( .thumb ) @ switch to Thumb now. This fixes and issue we had with SMP on mt6589. Tested-by: Matthias Brugger -- motzblog.wordpress.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/