Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753084AbbEPLX2 (ORCPT ); Sat, 16 May 2015 07:23:28 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:37370 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbbEPLXZ (ORCPT ); Sat, 16 May 2015 07:23:25 -0400 Message-ID: <555728A8.4030300@suse.cz> Date: Sat, 16 May 2015 13:23:20 +0200 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Albino Biasutti Neto CC: stable@vger.kernel.org, Linux Kernel , Takeshi Kihara , Simon Horman , Yoshihiro Kaneko , Ulf Hansson Subject: Re: [PATCH 3.12 137/142] mmc: sh_mmcif: Fix timeout value for command request References: <70c3d4ae1322b9e9bd7443ef574af5635234a0fa.1431761807.git.jslaby@suse.cz> <386484aac9a72283e58488159d0c9c76d9cf50d6.1431761807.git.jslaby@suse.cz> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 31 On 05/16/2015, 01:05 PM, Albino Biasutti Neto wrote: > 2015-05-16 4:38 GMT-03:00 Jiri Slaby : >> commit bad4371d87d1d1ed1aecd9c9cc21c41ac3f289c8 upstream. >> >> f9fd54f22e ("mmc: sh_mmcif: Use msecs_to_jiffies() for host->timeout") >> changed the timeout value from 1000 jiffies to 1s. In the case where >> HZ is 1000 the values are the same. However, for smaller HZ values the >> timeout is now smaller, 1s instead of 10s in the case of HZ=100. >> >> Since the timeout occurs in spite of a normal data transfer a timeout of >> 10s seems more appropriate. This restores the previous timeout in the >> case where HZ=100 and results in an increase over the previous timeout >> for larger values of HZ. >> >> Fixes: f9fd54f22e ("mmc: sh_mmcif: Use msecs_to_jiffies() for host->timeout") > > What is best 1s or 10s ? is 1s. The less time is faster, but HZ=100 > not 1000. 10s the longer answer. > > True ? Sorry, what? -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/