Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753304AbbEPL1u (ORCPT ); Sat, 16 May 2015 07:27:50 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:49994 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752569AbbEPL1t (ORCPT ); Sat, 16 May 2015 07:27:49 -0400 Message-ID: <1431775656.2341.10.camel@x220> Subject: Re: [PATCH v2 1/5] kasan, x86: move KASAN_SHADOW_OFFSET to the arch Kconfig From: Paul Bolle To: Andrey Ryabinin Cc: linux-kernel@vger.kernel.org, Dmitry Vyukov , Alexander Potapenko , David Keitel , Arnd Bergmann , Andrew Morton , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE..." Date: Sat, 16 May 2015 13:27:36 +0200 In-Reply-To: <1431698344-28054-2-git-send-email-a.ryabinin@samsung.com> References: <1431698344-28054-1-git-send-email-a.ryabinin@samsung.com> <1431698344-28054-2-git-send-email-a.ryabinin@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 34 On Fri, 2015-05-15 at 16:59 +0300, Andrey Ryabinin wrote: > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > +config KASAN_SHADOW_OFFSET > + hex > + default 0xdffffc0000000000 This sets CONFIG_KASAN_SHADOW_OFFSET for _all_ X86 configurations, doesn't it? > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > -config KASAN_SHADOW_OFFSET > - hex > - default 0xdffffc0000000000 if X86_64 While here it used to depend, at least, on HAVE_ARCH_KASAN. But grepping the tree shows the two places where CONFIG_KASAN_SHADOW_OFFSET is currently used are guarded by #ifdef CONFIG_KASAN. So perhaps the default line should actually read default 0xdffffc0000000000 if KASAN after the move. Would that work? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/