MIME-Version: 1.0
In-Reply-To: <1431724994-21601-4-git-send-email-Suravee.Suthikulpanit@amd.com>
References: <1431724994-21601-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1431724994-21601-4-git-send-email-Suravee.Suthikulpanit@amd.com>
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Sat, 16 May 2015 07:41:14 -0500
Message-ID: <CAErSpo7NkeXvtFH7jDNeYm6HTZO_G=r77EuJ8vOL4WUKSpQxAQ@mail.gmail.com>
Subject: Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device
 DMA coherency
To: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Cc: Rafael Wysocki <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, thomas.lendacky@amd.com,
        herbert@gondor.apana.org.au, David Miller <davem@davemloft.net>,
        Arnd Bergmann <arnd@arndb.de>, Mark Salter <msalter@redhat.com>,
        Hanjun Guo <hanjun.guo@linaro.org>, Al Stone <al.stone@linaro.org>,
        Grant Likely <grant.likely@linaro.org>, leo.duran@amd.com,
        linux-arm <linux-arm-kernel@lists.infradead.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linaro-acpi@lists.linaro.org, netdev <netdev@vger.kernel.org>,
        linux-crypto@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Murali Karicheri <m-karicheri2@ti.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 882
Lines: 22

On Fri, May 15, 2015 at 4:23 PM, Suravee Suthikulpanit
<Suravee.Suthikulpanit@amd.com> wrote:
> This patch refactors of_pci_dma_configure() into a more generic
> pci_dma_configure(), which can be reused by non-OF code.
> Then, it adds support for setting up PCI device DMA coherency from
> ACPI _CCA object that should normally be specified in the DSDT node
> of its PCI host bridge..

>From the changelog, it sounds like you might be able to split this
into two patches:

1) Refactor of_pci_dma_configure(), with no functional change
2) Add support for using _CCA

If that's possible, please do so to make this easier to review.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/