Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754399AbbEPPcg (ORCPT ); Sat, 16 May 2015 11:32:36 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:58497 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbbEPPcc (ORCPT ); Sat, 16 May 2015 11:32:32 -0400 Message-ID: <1431790345.2341.37.camel@x220> Subject: Re: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support From: Paul Bolle To: Jens Kuske Cc: Maxime Ripard , Emilio =?ISO-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Rob Herring , Chen-Yu Tsai , Vishnu Patekar , Hans de Goede , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Date: Sat, 16 May 2015 17:32:25 +0200 In-Reply-To: <1431707940-19372-8-git-send-email-jenskuske@gmail.com> References: <1431707940-19372-1-git-send-email-jenskuske@gmail.com> <1431707940-19372-8-git-send-email-jenskuske@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 28 Just a nit: a license mismatch. (I didn't bring this up in v1. Perhaps I should have.) On Fri, 2015-05-15 at 18:38 +0200, Jens Kuske wrote: > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c > + * This file is licensed under the terms of the GNU General Public > + * License version 2. This program is licensed "as is" without any > + * warranty of any kind, whether express or implied. This states the license is GPL v2. > +MODULE_LICENSE("GPL"); According to include/linux/module.h this states the license is GPL v2 or later. So I think that either the comment at the top of this file or the ident used in the MODULE_LICENSE() macro needs to change. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/