Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbbEPS5P (ORCPT ); Sat, 16 May 2015 14:57:15 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37905 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbbEPS5O (ORCPT ); Sat, 16 May 2015 14:57:14 -0400 MIME-Version: 1.0 X-Originating-IP: [213.57.247.249] In-Reply-To: <1431796166.15709.81.camel@perches.com> References: <1431796166.15709.81.camel@perches.com> From: Leon Romanovsky Date: Sat, 16 May 2015 21:56:52 +0300 Message-ID: Subject: Re: [RFC] Refactor kenter/kleave/kdebug macros To: Joe Perches Cc: dhowells , Linux-MM , "linux-kernel@vger.kernel.org" , linux-cachefs , linux-afs Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 25 On Sat, May 16, 2015 at 8:09 PM, Joe Perches wrote: > On Sat, 2015-05-16 at 20:01 +0300, Leon Romanovsky wrote: [] >> My question is how we should handle such duplicated debug print code? >> As possible solutions, I see five options: >> 1. Leave it as is. >> 2. Move it to general include file (for example linux/printk.h) and >> commonize the output to be consistent between different kdebug users. >> 3. Add CONFIG_*_DEBUG definition for every kdebug user. >> 4. Move everything to "#if 0" construction. >> 5. Move everything to "#if defined(__KDEBUG)" construction. > > 6: delete the macros and uses Thank you, It is indeed possible option, since in last six years there were no attempts to "open" this code. -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | leon@leon.nu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/