Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbbEPVT0 (ORCPT ); Sat, 16 May 2015 17:19:26 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:51097 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbbEPVTW (ORCPT ); Sat, 16 May 2015 17:19:22 -0400 Date: Sat, 16 May 2015 22:19:00 +0100 From: Russell King - ARM Linux To: Matthias Brugger Cc: Yingjoe Chen , Mark Rutland , Thomas Gleixner , Arnd Bergmann , Olof Johansson , "devicetree@vger.kernel.org" , Stephen Boyd , Pawel Moll , Catalin Marinas , Daniel Lezcano , "linux-kernel@vger.kernel.org" , Marc Carino , Rob Herring , linux-mediatek@lists.infradead.org, Sascha Hauer , srv_heupstream , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/9] ARM: correct secondary_startup_arm mode Message-ID: <20150516211900.GP2067@n2100.arm.linux.org.uk> References: <1431763110-443-1-git-send-email-yingjoe.chen@mediatek.com> <1431763110-443-2-git-send-email-yingjoe.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1766 Lines: 45 On Sat, May 16, 2015 at 11:08:36AM +0200, Matthias Brugger wrote: > 2015-05-16 9:58 GMT+02:00 Yingjoe Chen : > > secondary_startup_arm is used as ARM mode secondary start up function > > when ther kernel is compiled in THUMB mode, however the label itself > > is still in .thumb mode. readelf shows: > > > > 160979: c020a581 120 FUNC GLOBAL DEFAULT 2 secondary_startup_arm > > > > Make sure the label is in ARM mode as well. > > > > Signed-off-by: Yingjoe Chen > > --- > > arch/arm/kernel/head.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S > > index 3637973..58ee8a2 100644 > > --- a/arch/arm/kernel/head.S > > +++ b/arch/arm/kernel/head.S > > @@ -346,8 +346,8 @@ __turn_mmu_on_loc: > > > > #if defined(CONFIG_SMP) > > .text > > -ENTRY(secondary_startup_arm) > > .arm > > +ENTRY(secondary_startup_arm) > > THUMB( adr r9, BSYM(1f) ) @ Kernel is entered in ARM. > > THUMB( bx r9 ) @ If this is a Thumb-2 kernel, > > THUMB( .thumb ) @ switch to Thumb now. > > This fixes and issue we had with SMP on mt6589. > > Tested-by: Matthias Brugger Please ensure that this patch ends up in the patch system so it doesn't get forgotten about, thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/