Message-ID: <5557B54B.9010307@vanguardiasur.com.ar>
Date: Sat, 16 May 2015 18:23:23 -0300
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Organization: VanguardiaSur
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Antoine Tenart <antoine.tenart@free-electrons.com>
CC: sebastian.hesselbarth@gmail.com, dwmw2@infradead.org,
        computersforpeace@gmail.com, boris.brezillon@free-electrons.com,
        zmxu@marvell.com, jszhang@marvell.com,
        linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 05/12] mtd: pxa3xx_nand: rework flash detection and
 timing setup
References: <1431356341-31640-1-git-send-email-antoine.tenart@free-electrons.com> <1431356341-31640-6-git-send-email-antoine.tenart@free-electrons.com> <555128F0.30702@vanguardiasur.com.ar> <20150512143943.GC32171@kwain>
In-Reply-To: <20150512143943.GC32171@kwain>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1513
Lines: 47


On 05/12/2015 11:39 AM, Antoine Tenart wrote:
> Ezequiel,
> 
> On Mon, May 11, 2015 at 07:10:56PM -0300, Ezequiel Garcia wrote:
>>
>> On 05/11/2015 11:58 AM, Antoine Tenart wrote:
>> [..]
>>> -
>>> -	/* calculate flash information */
>>> -	host->read_id_bytes = (f->page_size == 2048) ? 4 : 2;
>>> -
>>
>> [..]
>>> @@ -1732,6 +1669,7 @@ static int alloc_nand_resource(struct platform_device *pdev)
>>>  		host->mtd = mtd;
>>>  		host->cs = cs;
>>>  		host->info_data = info;
>>> +		host->read_id_bytes = 4;
>>
>> Are you sure this is correct? The value is set according to the page
>> size before this patch.
> 
> Before reading the ID, the pxa3xx driver uses a default configuration,
> builtin_flash_types[0], which defines a page size of 2048 leading to set
> host->read_id_bytes to 4.
> 
> I'm using this default value here.
> 
> There might be an issue, as host->read_id_bytes isn't updated after
> reading the ID (and getting the actual page size). I don't know if this
> can be a problem. I can modify pxa3xx_nand_config_flash() to update
> host->read_id_bytes if needed. What do you think?
> 

Well, once the device is detected, READ_ID shouldn't be used, so I'm not
sure what's the point of that.

-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/