Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752381AbbEQHqK (ORCPT ); Sun, 17 May 2015 03:46:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59638 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751996AbbEQHp5 (ORCPT ); Sun, 17 May 2015 03:45:57 -0400 Date: Sun, 17 May 2015 09:45:53 +0200 From: Boris Brezillon To: LABBE Corentin Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, maxime.ripard@free-electrons.com, linux@arm.linux.org.uk, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, joe@perches.com, tj@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v9] crypto: Add Allwinner Security System crypto accelerator Message-ID: <20150517094553.7fd8d8a0@bbrezillon> In-Reply-To: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com> References: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1315 Lines: 37 Hello Corentin, On Thu, 14 May 2015 14:58:57 +0200 LABBE Corentin wrote: > > Hello > > This is the driver for the Security System included in Allwinner SoC A20. > The Security System (SS for short) is a hardware cryptographic accelerator that > support AES/MD5/SHA1/DES/3DES/PRNG algorithms. > It could be found on others Allwinner SoC: > - A10, A10s, A13, A31 and A33 manual give the same datasheet for SS than A20 > - A23 speak about a security system but without precisions > - A80 and A83T datasheet speak about a security system with more functions > (SHA224/SHA256/RSA/CRC), they will be supported in a separate driver > But I do not have access on any of those hardware, tests are welcome. > Maybe this is just a nitpick, but I would reverse the ordering of patches in this series. The biggest inconsistency is the fact that you're adding yourself as a maintainer of something that does not even exist. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/