Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbbEQJ4n (ORCPT ); Sun, 17 May 2015 05:56:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:58749 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584AbbEQJ4e (ORCPT ); Sun, 17 May 2015 05:56:34 -0400 Date: Sun, 17 May 2015 11:56:12 +0200 From: Sebastian Reichel To: Felipe Balbi Cc: NeilBrown , Mark Rutland , Pawel Moll , Ian Campbell , Rob Herring , Kumar Gala , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, NeilBrown , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek Subject: Re: [PATCH 2/2] twl4030_charger: find associated phy by more reliable means. Message-ID: <20150517095610.GA2612@earth> References: <20150322225053.22311.45510.stgit@notabene.brown> <20150322225248.22311.50385.stgit@notabene.brown> <20150508161205.GE16571@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN" Content-Disposition: inline In-Reply-To: <20150508161205.GE16571@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2195 Lines: 62 --J/dobhs11T7y2rNN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, May 08, 2015 at 11:12:05AM -0500, Felipe Balbi wrote: > On Mon, Mar 23, 2015 at 09:52:48AM +1100, NeilBrown wrote: > > From: NeilBrown > >=20 > > twl4030_charger currently finds the associated phy > > using usb_get_phy() which will return the first USB2 phy. > > If your platform has multiple such phys (as mine does), > > this is not reliable (and reliably fails on the GTA04). > >=20 > > Change to use devm_usb_get_phy_by_node(), having found the > > node by looking for an appropriately named sibling in > > device-tree. > >=20 > > This makes usb-charging dependent on correct device-tree > > configuration. > >=20 > > Acked-by: Pavel Machek > > Signed-off-by: NeilBrown > > --- >=20 > Sebastian, can I get your Acked-by here ? Acked-By: Sebastian Reichel -- Sebastian --J/dobhs11T7y2rNN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVWGW3AAoJENju1/PIO/qaztsP/jNWefxwkayLwpQTxDlRTzv9 qVUFeUFQTWOeXX7Ci3czk8tDvII8y3eoLPHH4aYkQx5UUmj/QZt/whkgJyzntEqv SNEBw8sKUS8oQHm+LYrM6OTQNo0BoRhzfVlW3gIY3k3KvI1D1hIa5qFgCMA76P2N g7fk/r1A8AE8z1fQ1izFAi2KyZmNJ37m3Xb6JJ5VzP9YLBIGft5aR0qzwI6o7CQN HHEzR4gmQkaTz3AFGc6ybBxso04HDPHLR0NwJWhKlBx/5G5EA1Q04bd8F1qe2aD3 gXI7Tebag2ASM543Cn+XdFSF5AAv813GvTyALlMMiufjbypvVTHz0fuZdqGaK3q/ 0544s8Vw2kpR7Mc4mRixN9xs/DyX0PmgOXNTQ8pxQKUgPjaYBk6Wx/eR59pet0kD Lf/lX6rrjMHvCXIQbiISgTE+mQBE+4WJF06bsvHrtz+86nGUSy3H/qqcI0y2jdkW khSoHmJCIQ1PDF0BtnhXC8gd+paC3TLcWuK1OUgUj3im+nPcup+CxYwGa6yBZq8r scOS7W3DHVtLx69uZz39NmtccBX9uEmOoAofmK5GRmSPcdGEPnpzPPsXBI6Qh7J+ tvpooXJPYQKru2dpW+q2DhUoKjUwHlqVUzQAXqSIETYpN9G/XsV65USxsXAMyCFt d3YBrgA5mg1Dofc0Y0Hh =EkTw -----END PGP SIGNATURE----- --J/dobhs11T7y2rNN-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/