Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751452AbbEQTnp (ORCPT ); Sun, 17 May 2015 15:43:45 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:57925 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbbEQTnh (ORCPT ); Sun, 17 May 2015 15:43:37 -0400 From: Laurent Pinchart To: Alex Dowad Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , "Lad, Prabhakar" , Ramakrishnan Muthukrishnan , "open list:MEDIA INPUT INFRA..." , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference Date: Sun, 17 May 2015 22:43:48 +0300 Message-ID: <1845070.nZfaVzKiG7@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.11-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1431883124-4937-1-git-send-email-alexinbeijing@gmail.com> References: <1431883124-4937-1-git-send-email-alexinbeijing@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1297 Lines: 40 Hi Alex, Thank you for the patch. On Sunday 17 May 2015 19:18:42 Alex Dowad wrote: > This fixes a checkpatch style error in vpfe_buffer_queue_setup. > > Signed-off-by: Alex Dowad Acked-by: Laurent Pinchart > --- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c > b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 06d48d5..04a687c > 100644 > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c > @@ -1095,7 +1095,7 @@ vpfe_buffer_queue_setup(struct vb2_queue *vq, const > struct v4l2_format *fmt, size = video->fmt.fmt.pix.sizeimage; > > if (vpfe_dev->video_limit) { > - while (size * *nbuffers > vpfe_dev->video_limit) > + while (size * (*nbuffers) > vpfe_dev->video_limit) > (*nbuffers)--; > } > if (pipe->state == VPFE_PIPELINE_STREAM_CONTINUOUS) { -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/