Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbbEQUi7 (ORCPT ); Sun, 17 May 2015 16:38:59 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37657 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbbEQUiw (ORCPT ); Sun, 17 May 2015 16:38:52 -0400 Message-ID: <5558FC58.4040407@gmail.com> Date: Sun, 17 May 2015 22:38:48 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Dan Carpenter CC: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy() References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-4-git-send-email-mateusz.kulikowski@gmail.com> <20150511082646.GI14154@mwanda> <55525BCD.5030901@gmail.com> <20150513082254.GQ14154@mwanda> <555505B3.3030107@gmail.com> <20150514231427.GY14154@mwanda> In-Reply-To: <20150514231427.GY14154@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1486 Lines: 41 On 15.05.2015 01:14, Dan Carpenter wrote: > On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: >> On 13.05.2015 10:22, Dan Carpenter wrote: >>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: >>>> On 11.05.2015 10:26, Dan Carpenter wrote: >> (...) >>>>> >>>>> Which part isn't aligned? I think they both are. >>>>> >>>> struct rtllib_rxb *prxb = prxbIndicateArray[j]; >>>> >>>> struct rtllib_rxb { >>>> u8 nr_subframes; >>>> struct sk_buff *subframes[MAX_SUBFRAME_COUNT == 64]; >>>> u8 dst[ETH_ALEN]; // here >>>> u8 src[ETH_ALEN]; // here >>>> } __packed; (...) > > I'm not positive it's "by design" though, this is staging code so maybe > they just added __packed to every struct. In fact, I'm pretty sure > unaligned pointers don't work on some arches so the __packed is probably > a bug. > I doubt anyone uses it on anything else than some low cost x86 netbooks. I removed __packed and did a small test today (download 10mb of garbage, check md5) - it doesn't seem to affect driver (on staging-testing, without this patchset). Nevertheless I would prefer to leave it like that for this patch set if it's OK with you and perhaps include it for next series I'll work on. Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/