Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbbEQX1U (ORCPT ); Sun, 17 May 2015 19:27:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33048 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbbEQX1L (ORCPT ); Sun, 17 May 2015 19:27:11 -0400 Date: Sun, 17 May 2015 16:27:10 -0700 From: Greg Kroah-Hartman To: Jagan Teki Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger , Florian Schilhabel Subject: Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy() Message-ID: <20150517232710.GA27330@kroah.com> References: <1431896221-7599-1-git-send-email-jteki@openedev.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431896221-7599-1-git-send-email-jteki@openedev.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 22 On Mon, May 18, 2015 at 02:27:01AM +0530, Jagan Teki wrote: > This patch fixes to use ether_addr_copy() instead of memcpy() > > Encounter this by applying checkpatch.pl against this file: > WARNING: Prefer ether_addr_copy() over memcpy() > if the Ethernet addresses are __aligned(2) > > Signed-off-by: Jagan Teki > Cc: Greg Kroah-Hartman > Cc: Larry Finger > Cc: Florian Schilhabel > --- > drivers/staging/rtl8712/os_intfs.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) You need to prove that the addresses are aligned, please do so in the changelog entry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/