Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbbERAJ5 (ORCPT ); Sun, 17 May 2015 20:09:57 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:35154 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbERAJt (ORCPT ); Sun, 17 May 2015 20:09:49 -0400 Message-ID: <55592DC8.8070807@lwfinger.net> Date: Sun, 17 May 2015 19:09:44 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jagan Teki , linux-kernel@vger.kernel.org CC: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Florian Schilhabel Subject: Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy() References: <1431896221-7599-1-git-send-email-jteki@openedev.com> In-Reply-To: <1431896221-7599-1-git-send-email-jteki@openedev.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2434 Lines: 65 On 05/17/2015 03:57 PM, Jagan Teki wrote: > This patch fixes to use ether_addr_copy() instead of memcpy() > > Encounter this by applying checkpatch.pl against this file: > WARNING: Prefer ether_addr_copy() over memcpy() > if the Ethernet addresses are __aligned(2) > > Signed-off-by: Jagan Teki > Cc: Greg Kroah-Hartman > Cc: Larry Finger > Cc: Florian Schilhabel > --- Can you assure us that you have carefully checked the the source address of addr->sa_data and padapter->eeprompriv.mac_addr are suitably aligned? At a minimum, have you tested this change on real hardware? Larry > drivers/staging/rtl8712/os_intfs.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c > index 6e776e5..0d27df6 100644 > --- a/drivers/staging/rtl8712/os_intfs.c > +++ b/drivers/staging/rtl8712/os_intfs.c > @@ -181,7 +181,7 @@ static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p) > struct sockaddr *addr = p; > > if (padapter->bup == false) > - memcpy(pnetdev->dev_addr, addr->sa_data, ETH_ALEN); > + ether_addr_copy(pnetdev->dev_addr, addr->sa_data); > return 0; > } > > @@ -395,8 +395,8 @@ static int netdev_open(struct net_device *pnetdev) > goto netdev_open_error; > if (r8712_initmac == NULL) > /* Use the mac address stored in the Efuse */ > - memcpy(pnetdev->dev_addr, > - padapter->eeprompriv.mac_addr, ETH_ALEN); > + ether_addr_copy(pnetdev->dev_addr, > + padapter->eeprompriv.mac_addr); > else { > /* We have to inform f/w to use user-supplied MAC > * address. > @@ -412,8 +412,8 @@ static int netdev_open(struct net_device *pnetdev) > * the eeprompriv.mac_addr should store the mac which > * users specify. > */ > - memcpy(padapter->eeprompriv.mac_addr, > - pnetdev->dev_addr, ETH_ALEN); > + ether_addr_copy(padapter->eeprompriv.mac_addr, > + pnetdev->dev_addr); > } > if (start_drv_threads(padapter) != _SUCCESS) > goto netdev_open_error; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/