Date: Mon, 18 May 2015 09:37:23 +0900
From: Simon Horman <horms@verge.net.au>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Albino Biasutti Neto <bino@riseup.net>, stable@vger.kernel.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Takeshi Kihara <takeshi.kihara.df@renesas.com>,
        Yoshihiro Kaneko <ykaneko0929@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 3.12 137/142] mmc: sh_mmcif: Fix timeout value for
 command request
Message-ID: <20150518003722.GA20545@verge.net.au>
References: <cover.1431761806.git.jslaby@suse.cz>
 <70c3d4ae1322b9e9bd7443ef574af5635234a0fa.1431761807.git.jslaby@suse.cz>
 <386484aac9a72283e58488159d0c9c76d9cf50d6.1431761807.git.jslaby@suse.cz>
 <CAHAf8W=Y7Vz0xm9gvfk3VayMukOdDjnwdO1T_trp-7AneyCRqQ@mail.gmail.com>
 <555728A8.4030300@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <555728A8.4030300@suse.cz>
Organisation: Horms Solutions Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1527
Lines: 34

On Sat, May 16, 2015 at 01:23:20PM +0200, Jiri Slaby wrote:
> On 05/16/2015, 01:05 PM, Albino Biasutti Neto wrote:
> > 2015-05-16 4:38 GMT-03:00 Jiri Slaby <jslaby@suse.cz>:
> >> commit bad4371d87d1d1ed1aecd9c9cc21c41ac3f289c8 upstream.
> >>
> >> f9fd54f22e ("mmc: sh_mmcif: Use msecs_to_jiffies() for host->timeout")
> >> changed the timeout value from 1000 jiffies to 1s. In the case where
> >> HZ is 1000 the values are the same. However, for smaller HZ values the
> >> timeout is now smaller, 1s instead of 10s in the case of HZ=100.
> >>
> >> Since the timeout occurs in spite of a normal data transfer a timeout of
> >> 10s seems more appropriate. This restores the previous timeout in the
> >> case where HZ=100 and results in an increase over the previous timeout
> >> for larger values of HZ.
> >>
> >> Fixes: f9fd54f22e ("mmc: sh_mmcif: Use msecs_to_jiffies() for host->timeout")
> > 
> > What is best 1s or 10s ? is 1s. The less time is faster, but HZ=100
> > not 1000. 10s the longer answer.
> > 
> > True ?
> 
> Sorry, what?

My understanding is that there is a desire to have a timeout of 10s
as 1s has turned out to be too short in practice.

Prior to f9fd54f22e the timeout was 10s for HZ=100, and it is my
understanding that on SH mobile HZ=100 is the normal case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/