Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751216AbbERDYg (ORCPT ); Sun, 17 May 2015 23:24:36 -0400 Received: from conssluserg002.nifty.com ([202.248.44.40]:58666 "EHLO conssluserg002-v.nifty.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750711AbbERDY0 (ORCPT ); Sun, 17 May 2015 23:24:26 -0400 X-Nifty-SrcIP: [209.85.212.177] MIME-Version: 1.0 In-Reply-To: References: <1431692764-17576-1-git-send-email-yamada.masahiro@socionext.com> Date: Mon, 18 May 2015 12:24:19 +0900 Message-ID: Subject: Re: [PATCH] serial: 8250_uniphier: add UniPhier serial driver From: Masahiro Yamada To: Matthias Brugger Cc: Peter Hurley , John Crispin , Greg Kroah-Hartman , Sebastian Andrzej Siewior , "linux-kernel@vger.kernel.org" , linux-serial@vger.kernel.org, Ricardo Ribalda Delgado , Andy Shevchenko , Jiri Slaby , "linux-arm-kernel@lists.infradead.org" , Alan Cox Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 34 Hi Matthias, 2015-05-16 18:17 GMT+09:00 Matthias Brugger : >> +/* >> + * The register map is slightly different from that of 8250. >> + * IO callbacks must be overridden for correct access to FCR, LCR, and MCR. >> + */ >> +static unsigned int uniphier_serial_in(struct uart_port *p, int offset) >> +{ >> + int valshift = 0; >> + >> + switch (offset) { >> + case UART_LCR: >> + valshift = 8; > > Please use a define for the value. Something like UNIPHIER_UART_LCR_SHIFT maybe. > Will do in v2. Thank you! -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/