Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbbERG0x (ORCPT ); Mon, 18 May 2015 02:26:53 -0400 Received: from mga14.intel.com ([192.55.52.115]:52612 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbbERG0r (ORCPT ); Mon, 18 May 2015 02:26:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,451,1427785200"; d="scan'208";a="730963853" Message-ID: <55598622.8060307@linux.intel.com> Date: Mon, 18 May 2015 14:26:42 +0800 From: "Fu, Zhonghui" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "brudley@broadcom.com" , Arend van Spriel , Franky Lin , "meuleman@broadcom.com" , Kalle Valo , "pieterpg@broadcom.com" , "hdegoede@redhat.com" , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list@broadcom.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver References: <555016DC.804@linux.intel.com> In-Reply-To: <555016DC.804@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2183 Lines: 68 Hi guys, Any comments about this patch? Thanks, Zhonghui On 2015/5/11 10:41, Fu, Zhonghui wrote: > ACPI will manage WiFi chip's power state during suspend/resume > process on some tablet platforms(such as ASUS T100TA). This is > not supported by brcmfmac driver now, and the context of WiFi > chip will be damaged after resume. This patch informs ACPI not > to manage WiFi chip's power state. > > Signed-off-by: Zhonghui Fu > Acked-by: Arend van Spriel > --- > Changes in v3: > - Have the assignment separate for the if statement. > > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > index 9b508bd..c960a12 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -1114,6 +1115,8 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func, > int err; > struct brcmf_sdio_dev *sdiodev; > struct brcmf_bus *bus_if; > + struct device *dev; > + struct acpi_device *adev; > > brcmf_dbg(SDIO, "Enter\n"); > brcmf_dbg(SDIO, "Class=%x\n", func->class); > @@ -1121,6 +1124,12 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func, > brcmf_dbg(SDIO, "sdio device ID: 0x%04x\n", func->device); > brcmf_dbg(SDIO, "Function#: %d\n", func->num); > > + /* prohibit ACPI power management for this device */ > + dev = &func->dev; > + adev = ACPI_COMPANION(dev); > + if (adev) > + adev->flags.power_manageable = 0; > + > /* Consume func num 1 but dont do anything with it. */ > if (func->num == 1) > return 0; > -- 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/