Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752418AbbERGwL (ORCPT ); Mon, 18 May 2015 02:52:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41527 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbbERGwC (ORCPT ); Mon, 18 May 2015 02:52:02 -0400 Date: Mon, 18 May 2015 08:51:58 +0200 From: Michal Kubecek To: Alex Dowad Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , "Lad, Prabhakar" , Laurent Pinchart , Ramakrishnan Muthukrishnan , "open list:MEDIA INPUT INFRA..." , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference Message-ID: <20150518065158.GA17391@unicorn.suse.cz> References: <1431883124-4937-1-git-send-email-alexinbeijing@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431883124-4937-1-git-send-email-alexinbeijing@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 36 On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: > This fixes a checkpatch style error in vpfe_buffer_queue_setup. > > Signed-off-by: Alex Dowad > --- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c > index 06d48d5..04a687c 100644 > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c > @@ -1095,7 +1095,7 @@ vpfe_buffer_queue_setup(struct vb2_queue *vq, const struct v4l2_format *fmt, > size = video->fmt.fmt.pix.sizeimage; > > if (vpfe_dev->video_limit) { > - while (size * *nbuffers > vpfe_dev->video_limit) > + while (size * (*nbuffers) > vpfe_dev->video_limit) > (*nbuffers)--; > } > if (pipe->state == VPFE_PIPELINE_STREAM_CONTINUOUS) { Style issue aside, is there a reason not to use if (size * *nbuffers > vpfe_dev->video_limit) *nbuffers = vpfe_dev->video_limit / size; instead? Michal Kubecek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/