Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752453AbbERGzA (ORCPT ); Mon, 18 May 2015 02:55:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:1560 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbbERGyx (ORCPT ); Mon, 18 May 2015 02:54:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,451,1427785200"; d="scan'208";a="711730522" Date: Mon, 18 May 2015 09:54:46 +0300 From: Laurentiu Palcu To: Krzysztof Kozlowski Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] Documentation: devicetree: Add TI BQ25890 bindings Message-ID: <20150518065446.GD14396@lpalcu-linux> References: <1431698778-29462-1-git-send-email-laurentiu.palcu@intel.com> <1431698778-29462-2-git-send-email-laurentiu.palcu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2744 Lines: 58 Hi Krzysztof, On Sat, May 16, 2015 at 08:53:42PM +0900, Krzysztof Kozlowski wrote: > 2015-05-15 23:06 GMT+09:00 Laurentiu Palcu : > > Signed-off-by: Laurentiu Palcu > > --- > > .../devicetree/bindings/power/bq25890.txt | 45 ++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power/bq25890.txt > > > > diff --git a/Documentation/devicetree/bindings/power/bq25890.txt b/Documentation/devicetree/bindings/power/bq25890.txt > > new file mode 100644 > > index 0000000..44f50a7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/bq25890.txt > > @@ -0,0 +1,45 @@ > > +Binding for TI bq25890 Li-Ion Charger > > + > > +Required properties: > > +- compatible: Should contain one of the following: > > + * "ti,bq25890" > > +- reg: integer, i2c address of the device. > > +- ti,battery-regulation-voltage: integer, maximum charging voltage (in uV); > > +- ti,charge-current: integer, maximum charging current (in uA); > > +- ti,termination-current: integer, charge will be terminated when current in > > + constant-voltage phase drops below this value (in uA); > > +- ti,precharge-current: integer, maximum charge current during precharge > > + phase (in uA); > > +- ti,minimum-sys-voltage: integer, when battery is charging and it is below > > + minimum system voltage, the system will be regulated above > > + minimum-sys-voltage setting (in uV); > > +- ti,boost-voltage: integer, VBUS voltage level in boost mode (in uV); > > +- ti,boost-max-current: integer, maximum allowed current draw in boost mode > > + (in uA). > > + > > +Optional properties: > > +- ti,boost-low-freq: boolean, if present boost mode frequency will be 500kHz, > > + otherwise 1.5MHz; > > +- ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the > > + input current will be the lower between the resistor setting and the IINLIM > > + register setting; > > +- ti,thermal-regulation-threshold: integer, temperature above which the charge > > + current is lowered, to avoid overheating (in degrees Celsius); > > What if property is absent? The temperature will be ignored? If so, > maybe consider adding such short statement about the default state? You're right, I should've mentioned it here. If it's missing, the default value will be used (120 degrees Celsius). I'll add a comment about it in v2. Thanks for reviewing, laurentiu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/