Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbbERIYv (ORCPT ); Mon, 18 May 2015 04:24:51 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:60063 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752392AbbERIYm (ORCPT ); Mon, 18 May 2015 04:24:42 -0400 Date: Mon, 18 May 2015 01:24:39 -0700 From: Christoph Hellwig To: Mike Snitzer Cc: dm-devel@redhat.com, Jens Axboe , Chris Mason , Jan Kara , linux-kernel@vger.kernel.org Subject: Re: [dm-devel] [PATCH for-4.2 01/14] block: remove management of bi_remaining when restoring original bi_end_io Message-ID: <20150518082439.GA5439@infradead.org> References: <1431637512-64245-1-git-send-email-snitzer@redhat.com> <1431637512-64245-2-git-send-email-snitzer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431637512-64245-2-git-send-email-snitzer@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 527 Lines: 10 In general this looks good. But as Jan mentioned you need to clear BIO_CHAIN when bi_remaining reaches zero, and I'd really prefer if bio_inc_remaining wuld not be left exported and folded into bio_chain so that we prevent new abuses from showing up and keep the code centralized. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/