Message-ID: <1431938797.2204.12.camel@x220>
Subject: Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX
 network controller
From: Paul Bolle <pebolle@tiscali.nl>
To: Aleksey Makarov <aleksey.makarov@auriga.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        David Daney <david.daney@cavium.com>,
        Sunil Goutham <sgoutham@cavium.com>, Maciej Czekaj <mjc@semihalf.com>,
        Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>,
        Tomasz Nowicki <tomasz.nowicki@linaro.org>,
        Robert Richter <rrichter@cavium.com>,
        Kamil Rytarowski <kamil@semihalf.com>,
        Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>,
        Sruthi Vangala <svangala@cavium.com>, Robert Richter <rric@kernel.org>,
        linux-arm-kernel@lists.infradead.org
Date: Mon, 18 May 2015 10:46:37 +0200
In-Reply-To: <1431747401-20847-3-git-send-email-aleksey.makarov@auriga.com>
References: <1431747401-20847-1-git-send-email-aleksey.makarov@auriga.com>
	 <1431747401-20847-3-git-send-email-aleksey.makarov@auriga.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1123
Lines: 33

Just a nit: a license mismatch.

On Fri, 2015-05-15 at 20:36 -0700, Aleksey Makarov wrote:
> --- /dev/null
> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.

This states the license is GPL v2 or later. (The other files used for
this module contain an identical comment.)

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
just GPL v2. So I think that either the license used in the comment at
the top of those files or the ident used in the MODULE_LICENSE() macro
needs to change.

Ditto for the thunder_bgx.ko and the nicvf.ko module.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/