Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753770AbbERKI1 (ORCPT ); Mon, 18 May 2015 06:08:27 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:33384 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753379AbbERKHJ (ORCPT ); Mon, 18 May 2015 06:07:09 -0400 Message-ID: <5559B65D.8020108@gmail.com> Date: Mon, 18 May 2015 11:52:29 +0200 From: Jens Kuske User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Maxime Ripard CC: =?windows-1252?Q?Emilio_L=F3pez?= , Mike Turquette , Linus Walleij , Rob Herring , Chen-Yu Tsai , Vishnu Patekar , Hans de Goede , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support References: <1431707940-19372-1-git-send-email-jenskuske@gmail.com> <1431707940-19372-8-git-send-email-jenskuske@gmail.com> <20150517143014.GH4004@lukather> In-Reply-To: <20150517143014.GH4004@lukather> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2431 Lines: 58 Hi, On 05/17/15 16:30, Maxime Ripard wrote: > On Fri, May 15, 2015 at 06:38:57PM +0200, Jens Kuske wrote: >> The H3 uses the same pin controller as previous SoC's from Allwinner. >> Add support for the pins controlled by the main PIO controller. >> >> Signed-off-by: Jens Kuske >> --- >> .../bindings/pinctrl/allwinner,sunxi-pinctrl.txt | 1 + >> drivers/pinctrl/sunxi/Kconfig | 8 + >> drivers/pinctrl/sunxi/Makefile | 1 + >> drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 522 +++++++++++++++++++++ >> 4 files changed, 532 insertions(+) >> create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt >> index fdd8046..c46af8e 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt >> @@ -16,6 +16,7 @@ Required properties: >> "allwinner,sun7i-a20-pinctrl" >> "allwinner,sun8i-a23-pinctrl" >> "allwinner,sun8i-a23-r-pinctrl" >> + "allwinner,sun8i-h3-pinctrl" >> - reg: Should contain the register physical address and length for the >> pin controller. >> >> diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig >> index 2eb893e..6c1cec5 100644 >> --- a/drivers/pinctrl/sunxi/Kconfig >> +++ b/drivers/pinctrl/sunxi/Kconfig >> @@ -43,6 +43,14 @@ config PINCTRL_SUN8I_A23_R >> depends on RESET_CONTROLLER >> select PINCTRL_SUNXI_COMMON >> >> +config PINCTRL_SUN8I_H3 >> + tristate "Allwinner H3 pinctrl driver" >> + default MACH_SUN8I >> + select PINCTRL_SUNXI_COMMON > > PINCTRL_SUNXI_COMMON should probably be turned into a tristate as well Probably, as well as all the other SoC specific drivers. But I think this should be a separate patch, its independent from this addition. But given the remove-panic problems I mentioned earlier this whole pinctrl-as-module topic needs some attention from more experienced devs I guess, this is beyond my current kernel knowledge. Regards, Jens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/