Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579AbbERKH4 (ORCPT ); Mon, 18 May 2015 06:07:56 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:52619 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752778AbbERKHt (ORCPT ); Mon, 18 May 2015 06:07:49 -0400 Message-ID: <1431943520.7490.6.camel@BR9GV9YG.de.ibm.com> Subject: Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster From: Ursula Braun To: Joe Perches Cc: Kashyap Desai , Sumit Saxena , Uday Lingala , "James E.J. Bottomley" , "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Rasmus Villemoes , Eugene Crosser , Ursula Braun Date: Mon, 18 May 2015 12:05:20 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15051810-0041-0000-0000-0000046C2C3F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3575 Lines: 102 Joe, thanks, we will add your qeth patch to our local library and submit it with one of our next shipments. Regards, Ursula Braun > > From: Joe Perches > To: Rasmus Villemoes , Evgeny > Cherkashin/Russia/IBM@IBMRU, Frank Blaschka > , Ursula Braun > Cc: Kashyap Desai , Sumit Saxena > , Uday Lingala > , "James E.J. Bottomley" > , "PDL,MEGARAIDLINUX" > , linux-scsi@vger.kernel.org, > linux-kernel@vger.kernel.org > Date: 05/12/2015 05:52 PM > Subject: Re: [PATCH] scsi: megaraid_sas: Prevent future %p > disaster > > ______________________________________________________________________ > > > > On Tue, 2015-05-12 at 16:04 +0200, Rasmus Villemoes wrote: > > On Tue, Feb 10 2015, Kashyap Desai > wrote: > > > > > Acked-by: Kashyap Desai > > > > > >> -----Original Message----- > > >> From: Rasmus Villemoes [mailto:linux@rasmusvillemoes.dk] > > >> Sent: Friday, February 06, 2015 8:04 PM > > >> To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. > Bottomley > > >> Cc: Rasmus Villemoes; megaraidlinux.pdl@avagotech.com; linux- > > >> scsi@vger.kernel.org; linux-kernel@vger.kernel.org > > >> Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster > > >> > > >> There is currently no %po format extension, so currently the > letters > > > "on" are > > >> simply skipped and the pointer is printed as expected (while > missing the > > > word > > >> on). However, it is probably only a matter of time before someone > comes > > > up > > >> with a %po extension, at which point this is likely to fail > > > spectacularly. > > >> > > >> Signed-off-by: Rasmus Villemoes > > > > Any chance either this minimal fix or Joe's more thorough cleanup > could > > get applied? There's still no %po extension, but there's certainly a > lot > > of proposals for more %p extensions flying around LKML, so I still > think > > the "only a matter of time" holds. > > There's also this one with %pM6: > --- > drivers/s390/net/qeth_l2_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/s390/net/qeth_l2_main.c > b/drivers/s390/net/qeth_l2_main.c > index 0ea0869..dc783047 100644 > --- a/drivers/s390/net/qeth_l2_main.c > +++ b/drivers/s390/net/qeth_l2_main.c > @@ -1420,8 +1420,8 @@ static void qeth_bridge_emit_host_event(struct > qeth_card *card, > env[i] = str[i]; i > ++; > } > if (code & > IPA_ADDR_CHANGE_CODE_MACADDR) { > - snprintf(str[i], > sizeof(str[i]), "MAC=%pM6", > - > &addr_lnid->mac); > + snprintf(str[i], > sizeof(str[i]), "MAC=%pM", > + > addr_lnid->mac); > env[i] = str[i]; i > ++; > } > snprintf(str[i], sizeof(str[i]), > "NTOK_BUSID=%x.%x.%04x", > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/