Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835AbbERKdR (ORCPT ); Mon, 18 May 2015 06:33:17 -0400 Received: from foss.arm.com ([217.140.101.70]:59224 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187AbbERKdH (ORCPT ); Mon, 18 May 2015 06:33:07 -0400 Date: Mon, 18 May 2015 11:33:02 +0100 From: Catalin Marinas To: Sudeep Holla Cc: Russell King , Rob Herring , Arnd Bergmann , Daniel Lezcano , "linux-kernel@vger.kernel.org" , Olof Johansson , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] ARM: simplify timer initialisation and remove arm_timer.h inclusion Message-ID: <20150518103302.GB21251@e104818-lin.cambridge.arm.com> References: <1430390662-18246-1-git-send-email-sudeep.holla@arm.com> <1430390662-18246-2-git-send-email-sudeep.holla@arm.com> <554239D5.4080301@arm.com> <555634F6.9060008@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555634F6.9060008@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1751 Lines: 38 On Fri, May 15, 2015 at 07:03:34PM +0100, Sudeep Holla wrote: > On 30/04/15 15:19, Sudeep Holla wrote: > >On 30/04/15 15:09, Rob Herring wrote: > >>On Thu, Apr 30, 2015 at 5:44 AM, Sudeep Holla wrote: > >>>The header asm/hardware/arm_timer.h is included in various machine > >>>specific files to access TIMER_CTRL and initialise to a known state. > >>>However that's not required as the clock{source,event} driver timer-sp > >>>initialises all the timer being used. > >> > >>I believe the idea is not to initialize the timers being used, but the > >>ones not being used and perhaps left running by the bootloader. Cases > >>where the interrupt is shared could cause a problem. > > Russell, can you confirm if that's the case ? Unless you want to test all these platforms, I would suggest we assume this is the case. The comments even state "Initialise to a known state (all timers off)". > >Ah OK, makes sense. I will wait for Russell to confirm. The main idea > >was to keep the header file having offsets local to driver/clocksource > >and avoid sharing it in include/linux but looks like that's not possible. > > Since we need this driver on ARM64, we might have to end up sharing the > header file with offsets if required for ARM platforms(though it would > be good to avoid it if there's any better alternative solution than that) Can you not just move the definitions to include/clocksource/timer-sp804.h and add some SP804_ prefix to avoid name collisions? -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/