Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753756AbbERKog (ORCPT ); Mon, 18 May 2015 06:44:36 -0400 Received: from foss.arm.com ([217.140.101.70]:59344 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434AbbERKo2 (ORCPT ); Mon, 18 May 2015 06:44:28 -0400 Message-ID: <5559C288.7020703@arm.com> Date: Mon, 18 May 2015 11:44:24 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: Sudeep Holla , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Daniel Lezcano , Thomas Gleixner , Arnd Bergmann , Olof Johansson Subject: Re: [PATCH 1/2] ARM: simplify timer initialisation and remove arm_timer.h inclusion References: <1430390662-18246-1-git-send-email-sudeep.holla@arm.com> <1430390662-18246-2-git-send-email-sudeep.holla@arm.com> <554239D5.4080301@arm.com> <20150518104223.GT2067@n2100.arm.linux.org.uk> In-Reply-To: <20150518104223.GT2067@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 36 On 18/05/15 11:42, Russell King - ARM Linux wrote: > On Thu, Apr 30, 2015 at 03:19:01PM +0100, Sudeep Holla wrote: >> >> >> On 30/04/15 15:09, Rob Herring wrote: >>> On Thu, Apr 30, 2015 at 5:44 AM, Sudeep Holla wrote: >>>> The header asm/hardware/arm_timer.h is included in various machine >>>> specific files to access TIMER_CTRL and initialise to a known state. >>>> However that's not required as the clock{source,event} driver timer-sp >>>> initialises all the timer being used. >>> >>> I believe the idea is not to initialize the timers being used, but the >>> ones not being used and perhaps left running by the bootloader. Cases >>> where the interrupt is shared could cause a problem. >>> >> >> Ah OK, makes sense. I will wait for Russell to confirm. The main idea >> was to keep the header file having offsets local to driver/clocksource >> and avoid sharing it in include/linux but looks like that's not possible. > > An alternative would be to have a new function, something like > sp804_disable() which takes the virtual address of the timer. > That'd still allow the platforms to disable all timers, but > without exposing the register stuff to them. > Yes that's much better, will re-spin the patch accordingly. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/