Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923AbbERLCZ (ORCPT ); Mon, 18 May 2015 07:02:25 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:32974 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbbERLCR (ORCPT ); Mon, 18 May 2015 07:02:17 -0400 Date: Mon, 18 May 2015 13:02:14 +0200 From: Johan Hovold To: grygorii.strashko@linaro.org Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only Message-ID: <20150518110214.GC28127@localhost> References: <1431696321-7257-1-git-send-email-grygorii.strashko@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431696321-7257-1-git-send-email-grygorii.strashko@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1673 Lines: 48 On Fri, May 15, 2015 at 04:25:21PM +0300, grygorii.strashko@linaro.org wrote: > From: Grygorii Strashko > > Now GPIOs, wich are requested as IRQ only, will not be displayed > through GPIO debugfs. For example: > # cat /proc/interrupts > CPU0 CPU1 > ... > 209: 0 0 4805d000.gpio 11 Edge 0-0021 > > # cat /debug/gpio > ... > GPIOs 160-191, platform/4805d000.gpio, gpio: > <--- no info about gpio used as IRQ only here > > GPIOs 192-223, platform/48051000.gpio, gpio: > gpio-203 (vtt_fixed ) out hi > ... > > Hence, improve GPIO debugfs code to show such kind of gpio and print > IRQ number also. In addition, add marker "requested" for GPIOs wich > were requested by using gpioX_request(). > > After this patch sys/kernel/debug/gpio will produce following output: > > # cat /debug/gpio > ... > GPIOs 160-191, platform/4805d000.gpio, gpio: > gpio-171 ((null) ) in hi IRQ209 > > GPIOs 192-223, platform/48051000.gpio, gpio: > gpio-203 (vtt_fixed ) out hi requested This is backwards. All gpios *should* be requested. *If* we are to include not-requested gpios in the debug output, then it is those pins that need to be marked as not-requested. The irq-number mapping could perhaps be useful, but it should go in a separate patch. I'd suggest adding a '-' before the irq-number (e.g. "IRQ-209"). Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/