Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbbERMT3 (ORCPT ); Mon, 18 May 2015 08:19:29 -0400 Received: from smtp-out-025.synserver.de ([212.40.185.25]:1059 "EHLO smtp-out-023.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753940AbbERMTV (ORCPT ); Mon, 18 May 2015 08:19:21 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 15971 Message-ID: <5559D8C5.9060407@metafoo.de> Date: Mon, 18 May 2015 14:19:17 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: =?UTF-8?B?VXJzIEbDpHNzbGVy?= , jic23@kernel.org, angelo.compagnucci@gmail.com CC: iivanov@mm-sol.com, ezequiel.garcia@imgtec.com, jacob.jun.pan@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: adc128s052: add support for adc122s021 References: <1431950676-22379-1-git-send-email-urs.fassler@bytesatwork.ch> <1431950676-22379-2-git-send-email-urs.fassler@bytesatwork.ch> In-Reply-To: <1431950676-22379-2-git-send-email-urs.fassler@bytesatwork.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 30 > --- a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt > +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt > @@ -1,7 +1,7 @@ > -* Texas Instruments' ADC128S052 ADC chip > +* Texas Instruments' ADC128S052 and ADC122S021 ADC chip > > Required properties: > - - compatible: Should be "ti,adc128s052" > + - compatible: Should be "adc128s052" or "adc122s021" Why are you removing the vendor prefix? The compatible string is not valid without a vendor prefix. > - reg: spi chip select number for the device > - vref-supply: The regulator supply for ADC reference voltage > > @@ -11,7 +11,7 @@ Recommended properties: > > Example: > adc@0 { > - compatible = "ti,adc128s052"; > + compatible = "adc128s052"; Indention. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/