Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752670AbbERM6x (ORCPT ); Mon, 18 May 2015 08:58:53 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:53898 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbbERM6k (ORCPT ); Mon, 18 May 2015 08:58:40 -0400 Message-ID: <5559E1FB.2070004@roeck-us.net> Date: Mon, 18 May 2015 05:58:35 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Denys Vlasenko , Vijaya Mohan Guvva CC: Fabian Frederick , Anil Gurumurthy , Christoph Hellwig , Ben Hutchings , James Bottomley , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] bfa: deinline __bfa_trc() and __bfa_trc32() References: <1431940681-15915-1-git-send-email-dvlasenk@redhat.com> In-Reply-To: <1431940681-15915-1-git-send-email-dvlasenk@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 612 Lines: 18 On 05/18/2015 02:18 AM, Denys Vlasenko wrote: > __bfa_trc() compiles to 115 bytes of machine code. > With this .config: http://busybox.net/~vda/kernel_config > there are 1494 calls of __bfa_trc(). > > __bfa_trc32() is very similar, so it is uninlined too. > However, it appears to be unused, therefore this patch > ifdefs it out. > Why not just remove it ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/