Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753311AbbERNCd (ORCPT ); Mon, 18 May 2015 09:02:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48001 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbbERNCU (ORCPT ); Mon, 18 May 2015 09:02:20 -0400 Message-ID: <5559E2C4.1020900@redhat.com> Date: Mon, 18 May 2015 15:01:56 +0200 From: Denys Vlasenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Guenter Roeck , Vijaya Mohan Guvva CC: Fabian Frederick , Anil Gurumurthy , Christoph Hellwig , Ben Hutchings , James Bottomley , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] bfa: deinline __bfa_trc() and __bfa_trc32() References: <1431940681-15915-1-git-send-email-dvlasenk@redhat.com> <5559E1FB.2070004@roeck-us.net> In-Reply-To: <5559E1FB.2070004@roeck-us.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 726 Lines: 19 On 05/18/2015 02:58 PM, Guenter Roeck wrote: > On 05/18/2015 02:18 AM, Denys Vlasenko wrote: >> __bfa_trc() compiles to 115 bytes of machine code. >> With this .config: http://busybox.net/~vda/kernel_config >> there are 1494 calls of __bfa_trc(). >> >> __bfa_trc32() is very similar, so it is uninlined too. >> However, it appears to be unused, therefore this patch >> ifdefs it out. >> > Why not just remove it ? I'm not familiar with the code, figured maintainers know better. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/