Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753741AbbERNGV (ORCPT ); Mon, 18 May 2015 09:06:21 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:34014 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbbERNGM (ORCPT ); Mon, 18 May 2015 09:06:12 -0400 From: "Grygorii.Strashko@linaro.org" X-Google-Original-From: "Grygorii.Strashko@linaro.org" Message-ID: <5559E3C0.1040207@linaro.org> Date: Mon, 18 May 2015 16:06:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Johan Hovold CC: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only References: <1431696321-7257-1-git-send-email-grygorii.strashko@linaro.org> <20150518110214.GC28127@localhost> In-Reply-To: <20150518110214.GC28127@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2831 Lines: 79 Hi Johan, On 05/18/2015 02:02 PM, Johan Hovold wrote: > On Fri, May 15, 2015 at 04:25:21PM +0300, grygorii.strashko@linaro.org wrote: >> From: Grygorii Strashko >> >> Now GPIOs, wich are requested as IRQ only, will not be displayed >> through GPIO debugfs. For example: >> # cat /proc/interrupts >> CPU0 CPU1 >> ... >> 209: 0 0 4805d000.gpio 11 Edge 0-0021 >> >> # cat /debug/gpio >> ... >> GPIOs 160-191, platform/4805d000.gpio, gpio: >> <--- no info about gpio used as IRQ only here >> >> GPIOs 192-223, platform/48051000.gpio, gpio: >> gpio-203 (vtt_fixed ) out hi >> ... >> >> Hence, improve GPIO debugfs code to show such kind of gpio and print >> IRQ number also. In addition, add marker "requested" for GPIOs wich >> were requested by using gpioX_request(). >> >> After this patch sys/kernel/debug/gpio will produce following output: >> >> # cat /debug/gpio >> ... >> GPIOs 160-191, platform/4805d000.gpio, gpio: >> gpio-171 ((null) ) in hi IRQ209 >> >> GPIOs 192-223, platform/48051000.gpio, gpio: >> gpio-203 (vtt_fixed ) out hi requested > > This is backwards. All gpios *should* be requested. *If* we are to > include not-requested gpios in the debug output, then it is those pins > that need to be marked as not-requested. Sry, but I didn't fully understand your point here ( - Why is it backward? Now GPIO can be requested in three ways: 1) As pure GPIO (gpioX_request()) 2) As pure GPIO IRQ, especially in DT boot case. DT: interrupt-parent = <&gpio6>; interrupts = <11 IRQ_TYPE_EDGE_FALLING>; Code: platform_get_irq() or of_irq_get() request_irq() 3) combination of (1) and (2) with one restriction - GPIO direction should be 'In' and can't be changed. Personally I'm using this case for debug purposes to do a fast check of GPIO pin state through GPIO sysfs (GPIO export) when such GPIO is used as GPIO IRQ in some driver and I don't see that corresponding IRQ is triggered as expected. So, this patch just adds missed information in GPIO debugfs for the case (2) in general. Of course, format of the marker "requested" is discussable. Could be: - "requested" --> "not-requested" - "I R" or "I G" where I - IRQ, G - GPIO, R - requested - etc. > > The irq-number mapping could perhaps be useful, but it should go in a > separate patch. I'd suggest adding a '-' before the irq-number (e.g. > "IRQ-209"). I've thought about this, but finally decided not to split it. Could be done, if you insist ) -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/