Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550AbbEROEK (ORCPT ); Mon, 18 May 2015 10:04:10 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:36637 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbbERODw (ORCPT ); Mon, 18 May 2015 10:03:52 -0400 MIME-Version: 1.0 In-Reply-To: <5559E4B0.70506@linaro.org> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <1431158038-3813-10-git-send-email-mcoquelin.stm32@gmail.com> <5559E4B0.70506@linaro.org> Date: Mon, 18 May 2015 16:03:49 +0200 Message-ID: Subject: Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver From: Maxime Coquelin To: Daniel Lezcano Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Joe Perches , Vladimir Zapolskiy , Lee Jones , Daniel Thompson , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1926 Lines: 51 2015-05-18 15:10 GMT+02:00 Daniel Lezcano : > On 05/09/2015 09:53 AM, Maxime Coquelin wrote: >> >> STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. >> The drivers detects whether the time is 16 or 32 bits, and applies a >> 1024 prescaler value if it is 16 bits. >> >> Reviewed-by: Linus Walleij >> Tested-by: Chanwoo Choi >> Signed-off-by: Maxime Coquelin >> --- >> drivers/clocksource/Kconfig | 8 ++ >> drivers/clocksource/Makefile | 1 + >> drivers/clocksource/timer-stm32.c | 184 >> ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 193 insertions(+) >> create mode 100644 drivers/clocksource/timer-stm32.c >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index bf9364c..2443520 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -106,6 +106,14 @@ config CLKSRC_EFM32 >> Support to use the timers of EFM32 SoCs as clock source and >> clock >> event device. >> >> +config CLKSRC_STM32 >> + bool "Clocksource for STM32 SoCs" if !ARCH_STM32 >> + depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST) > > > Are the interactive bool and the 'COMPILE_TEST' necessary ? > The interactive bool is necessary if we want to be able to select/deselect it in COMPILE_TEST configuration. And personnaly, I think COMPILE_TEST use makes sense. Note that other timer drivers are doing the same thing today (CLKSRC_EFM32, SH_TIMER_CMT, EM_TIMER_STI...). Do you have a specific concern regarding COMPILE_TEST? Kind regards, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/