Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbbEROjO (ORCPT ); Mon, 18 May 2015 10:39:14 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42628 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbbEROjM (ORCPT ); Mon, 18 May 2015 10:39:12 -0400 Date: Mon, 18 May 2015 17:38:44 +0300 From: Dan Carpenter To: Jagan Teki Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger , Florian Schilhabel , Greg Kroah-Hartman Subject: Re: [PATCH v2] staging: rtl8712: Use ether_addr_copy() instead of memcpy() Message-ID: <20150518143844.GK14154@mwanda> References: <1431958626-4345-1-git-send-email-jteki@openedev.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431958626-4345-1-git-send-email-jteki@openedev.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 19 On Mon, May 18, 2015 at 07:47:06PM +0530, Jagan Teki wrote: > struct eeprom_priv { > u8 bautoload_fail_flag; /* 0 1 */ > u8 bempty; /* 1 1 */ > u8 sys_config; /* 2 1 */ > u8 mac_addr[6]; /* 3 6 */ > ...... > }; This means it's not aligned as we want. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/