Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbbERQFD (ORCPT ); Mon, 18 May 2015 12:05:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60840 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825AbbERQEy (ORCPT ); Mon, 18 May 2015 12:04:54 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: mmarek@suse.cz, dwmw2@infradead.org cc: dhowells@redhat.com, Linus Torvalds , Abelardo Ricart III , Linux Kernel Mailing List , Sedat Dilek , keyrings@linux-nfs.org, Rusty Russell , LSM List Subject: Should we automatically generate a module signing key at all? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <31153.1431965087.1@warthog.procyon.org.uk> Date: Mon, 18 May 2015 17:04:47 +0100 Message-ID: <31154.1431965087@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1308 Lines: 36 Hi Michal, Dave, Should we automatically generate a module signing key at all since that has the possibility of accidentally overwriting a key that the builder has placed in the tree? Should we instead provide a script: ./scripts/generate-key That generates a key if run and make it so that the build fails if you turn on module signing and there's no key. The script could then be parameterised, eg: ./scripts/generate-key -n dhowells@redhat.com -k rsa2048 -d sha256 \ -o ./my-signing-key.priv -x ./my-signing-key.x509 \ -p "correct horse battery staple" Yes, this might throw randconfig into a strop but that can be dealt with by: (1) Requiring anyone who runs randconfig to provide a key first just in case. (2) Marking the CONFIG_MODULE_SIG_ALL option to be ignored by randconfig - it only applies during installation anyway. (3) Accept that module *installation* will fail due to a lack of private key and just handle a complete lack of X.509 certs in the source and build dirs when assembling system_certificates.S. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/