Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754095AbbERQFu (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 May 2015 12:05:50 -0400
Received: from mail-pa0-f67.google.com ([209.85.220.67]:33259 "EHLO
	mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754000AbbERQFm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 May 2015 12:05:42 -0400
Date: Mon, 18 May 2015 21:35:28 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "lambert.quentin@gmail.com" <lambert.quentin@gmail.com>,
        "mdcasey@chabloom.com" <mdcasey@chabloom.com>,
        "julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
        "kolbeinnkarls@gmail.com" <kolbeinnkarls@gmail.com>,
        "himangi774@gmail.com" <himangi774@gmail.com>,
        "joe@perches.com" <joe@perches.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Babu, Viswanathan (V.)" <vbabu3@visteon.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather
 assignment
Message-ID: <20150518160528.GA2927@sudip-PC>
References: <20150518144539.GA10481@visteon-gnana>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150518144539.GA10481@visteon-gnana>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1144
Lines: 32

On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> setup_timer is used for timer parameter setup rather than direct
> assignment
> 
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>

your From: name and Signed-off-by: names are not matching. They should
be same.

> ---
<snip>
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -59,9 +59,8 @@ EXPORT_SYMBOL(rt_global_debug_component);
>  
>  void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
>  {
> -	ptimer->function = fun;
> -	ptimer->data = data;
>  	init_timer(ptimer);
> +	setup_timer(ptimer, fun, data);
setup_timer is calling __setup_timer which is again calling __init_timer
here we already have an init_timer which is also calling __init_timer.
so now __init_timer gets executed two times for one timer. 

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/