Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932252AbbERQJb (ORCPT ); Mon, 18 May 2015 12:09:31 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42590 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932147AbbERQJX (ORCPT ); Mon, 18 May 2015 12:09:23 -0400 Date: Mon, 18 May 2015 19:08:59 +0300 From: Dan Carpenter To: Jagan Teki Cc: devel@driverdev.osuosl.org, Florian Schilhabel , Larry Finger , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman Subject: Re: [PATCH v2] staging: rtl8712: Use ether_addr_copy() instead of memcpy() Message-ID: <20150518160859.GM14154@mwanda> References: <1431958626-4345-1-git-send-email-jteki@openedev.com> <20150518143844.GK14154@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 29 #include struct foo { unsigned char one; unsigned char two; unsigned char three; unsigned char mac_addr[6]; unsigned short channel_plan; }; int main(void) { struct foo *p = NULL; printf("%x\n", &p->mac_addr); return 0; } This program does not print an even number so the alignment is off. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/