Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932631AbbERQmx (ORCPT ); Mon, 18 May 2015 12:42:53 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:34191 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932216AbbERQmu (ORCPT ); Mon, 18 May 2015 12:42:50 -0400 Date: Mon, 18 May 2015 22:12:42 +0530 From: Sudip Mukherjee To: Joe Perches Cc: "DHANAPAL, GNANACHANDRAN (G.)" , "gregkh@linuxfoundation.org" , "lambert.quentin@gmail.com" , "mdcasey@chabloom.com" , "julia.lawall@lip6.fr" , "kolbeinnkarls@gmail.com" , "himangi774@gmail.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Babu, Viswanathan (V.)" Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment Message-ID: <20150518164242.GB12138@sudip-PC> References: <20150518144539.GA10481@visteon-gnana> <20150518160528.GA2927@sudip-PC> <1431966363.2870.24.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431966363.2870.24.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 32 On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote: > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: > > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote: > > > setup_timer is used for timer parameter setup rather than direct > > > assignment > > > > > > Signed-off-by: Gnanachandran Dhanapal > > > > your From: name and Signed-off-by: names are not matching. They should > > be same. > > If there's a specific "From: " in the _body_ of the email, > that's true, but the sender email "From: " header and the > Signed-off-by: line do not have to match. But Greg usually rejects these patches where the sender "From:" header and Signed-off-by: doesnot match. Just for example: https://lkml.org/lkml/2014/11/25/924 regards sudip > > A "From: " line in the email body should only be used when > the patch is from a different sender than the sign-off. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/