Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbbERQyW (ORCPT ); Mon, 18 May 2015 12:54:22 -0400 Received: from smtp-out-025.synserver.de ([212.40.185.25]:1053 "EHLO smtp-out-023.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751713AbbERQyU (ORCPT ); Mon, 18 May 2015 12:54:20 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 21004 Message-ID: <555A1938.6070502@metafoo.de> Date: Mon, 18 May 2015 18:54:16 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Daniel Baluta , jic23@kernel.org, srinivas.pandruvada@linux.intel.com CC: knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/2] Introduce PM runtime helper functions References: <1431966328-11058-1-git-send-email-daniel.baluta@intel.com> In-Reply-To: <1431966328-11058-1-git-send-email-daniel.baluta@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 17 On 05/18/2015 06:25 PM, Daniel Baluta wrote: > Working on a new driver I noticed that there is a fair amount of duplicate > code for adding PM runtime support. > > First patch refactors the PM runtime support in a new header > introducing functions for setup/cleanup and > set power state. Makes sense, but none of the functions look awfully IIO specific. I'd say these are helper functions that belong into the PM core itself. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/