Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753825AbbERRTu (ORCPT ); Mon, 18 May 2015 13:19:50 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:47305 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167AbbERRTs (ORCPT ); Mon, 18 May 2015 13:19:48 -0400 Date: Mon, 18 May 2015 18:19:46 +0100 From: Al Viro To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Dave Chinner , xfs@oss.sgi.com Subject: Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance() Message-ID: <20150518171946.GY7232@ZenIV.linux.org.uk> References: <1431969231-12834-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431969231-12834-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 17 On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote: > * If the block order is wrong, swap the arguments. > */ > - if ((swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp))) { > - xfs_da_state_blk_t *tmp; /* temp for block swap */ > + swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp); > + if (swap) > + swap(blk1, blk2); Egads... Have you even read what you'd written? Yes, sure, preprocessor will do the right thing, but it's a very noticable annoyance for somebody reading that. Rename the bleeding flag, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/