Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891AbbERRte (ORCPT ); Mon, 18 May 2015 13:49:34 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:49092 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbbERRtd (ORCPT ); Mon, 18 May 2015 13:49:33 -0400 X-IronPort-AV: E=Sophos;i="5.13,454,1427752800"; d="scan'208";a="151476953" Date: Mon, 18 May 2015 19:49:30 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "DHANAPAL, GNANACHANDRAN (G.)" cc: "gregkh@linuxfoundation.org" , "lambert.quentin@gmail.com" , "mdcasey@chabloom.com" , "julia.lawall@lip6.fr" , "kolbeinnkarls@gmail.com" , "himangi774@gmail.com" , "joe@perches.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Babu, Viswanathan (V.)" Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment In-Reply-To: <20150518144539.GA10481@visteon-gnana> Message-ID: References: <20150518144539.GA10481@visteon-gnana> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 17 > void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data) > { > - ptimer->function = fun; > - ptimer->data = data; > init_timer(ptimer); > + setup_timer(ptimer, fun, data); > } setup_timer also subsumes init_timer. Check the definition. Probably you can delete this function completely. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/