Message-ID: <555A2810.3080501@plumgrid.com>
Date: Mon, 18 May 2015 10:57:36 -0700
From: Alexei Starovoitov <ast@plumgrid.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Wang Nan <wangnan0@huawei.com>, paulus@samba.org, a.p.zijlstra@chello.nl,
        mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
        jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net,
        brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com
CC: lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com
Subject: Re: [RFC PATCH v3 08/37] bpf tools: Define basic interface
References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-9-git-send-email-wangnan0@huawei.com>
In-Reply-To: <1431860222-61636-9-git-send-email-wangnan0@huawei.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 811
Lines: 27

On 5/17/15 3:56 AM, Wang Nan wrote:
> bpf_open_object() and bpf_close_object() are open and close function of
> eBPF object files. 'struct bpf_object' will be handler of one object
> file. Its internal structure is hide to user.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> ---
...
> +
> +struct bpf_object *bpf_open_object(const char *path)
> +{
> +	return NULL;
> +}
> +
> +void bpf_close_object(struct bpf_object *object)
> +{
> +	return 0;
> +}

I'm not a fan of introducing empty helpers. I would
squash it with the patch that actually adds meat to it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/